Probe timeouts #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adhityaa Chandrasekar <adtac@google.com>
[1.20] APF e2e: disable drown-out tests temporarily
modify addon test to cover the entire migration logic
This reverts commit 8b4e164.
Signed-off-by: Hanlin Shi <shihanlin9@gmail.com>
…ric-fix [1.20.1] Add AcceleratorStats to cri_stats_provider for 1.20
FibreChannel volume plugin misses one important step when removing a device: "multipath -f". It flushes all multipath buffers to its individual paths. Without it, a filesystem on the device may get corrupted.
If a FibreChannel device is used as a block volume, we should flush its I/O before deleting its device. It is not strictly necessary when it's used as a filesystem (mount), but it won't hurt either.
…k-of-#97127-upstream-release-1.20 [1.20.1] Automated cherry pick of kubernetes#97127: Revert "iAdd host IP to etcd listen client URLs."
Signed-off-by: pacoxu <paco.xu@daocloud.io>
vendor: update cAdvisor to v0.38.6
cherry-pick to 1.20: etcd version for 1.19 is 3.4.13 for cve fixes
Add additional logging for "Mount cannot be satisfied for container" error to help debug kubernetes#85330.
…kubeconfig files." This reverts commit 49afcfa.
…ck-of-#97013-upstream-release-1.20 Automated cherry pick of kubernetes#97013: Fix FibreChannel volume plugin corrupting filesystem on
…-of-#97253-upstream-release-1.20 Revert "Use host IP instead of localhost for control plane component …
…ick-of-#97016-origin-release-1.20 [1.20.1] Automated cherry pick of kubernetes#97016: fix migration logic
Signed-off-by: Kevin Klues <kklues@nvidia.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
…ck-of-#97259-upstream-release-1.20 Automated cherry pick of kubernetes#97259 upstream release 1.20
In d9cfd77 and d70d04f we added support for reproducible builds for individual binaries (like kube-apiserver), however we need to thread this support when we build binaries with docker as well (say during "make quick-release"). Essentially, if GOLDFLAGS is set explicitly by someone either to a valid value they would like to use or empty ("") then we pick that up. If it is not set we should avoid setting GOLDFLAGS to empty. This ensures that we support the same functionality documented here: https://github.com/kubernetes/kubernetes/blob/master/build/root/Makefile#L82-L85 Signed-off-by: Davanum Srinivas <davanum@gmail.com>
…ck-of-#97006-upstream-release-1.20 Automated cherry pick of kubernetes#97006: Fix cadvisor machine metrics
…ry-pick-of-#97254-upstream-release-1.20 Automated cherry pick of kubernetes#97254: Create OWNERS for most of the API Priority and Fairness impl
…k-of-#97427-upstream-release-1.20 Automated cherry pick of kubernetes#97427: Fix bug in CPUManager with race on map acccess
…f-#97699-upstream-release-1.20 Automated cherry pick of kubernetes#97699: Ensure reproducible builds when build through docker
…pick-of-#97417-upstream-release-1.20 Automated cherry pick of kubernetes#97417: fix azure file secret not found issue
…k-of-#97323-upstream-release-1.20 Automated cherry pick of kubernetes#97323: fix the deadlock in priority and fairness config controller
…48-1.20 Cherry pick 443 and 448 from cloud provider azure to 1.20
…pick-of-#97082-upstream-release-1.20 Automated cherry pick of kubernetes#97082: fix: azure file latency issue for metadata-heavy workload
Previous behavior was to release the ip only upon success, but it should be released on failure as well. Otherwise, an IP address will be unnecessarily consumed due to an in-error service.
…e during creating clusterip Signed-off-by: pacoxu <paco.xu@daocloud.io>
…ck-of-#97740-upstream-release-1.20 Automated cherry pick of kubernetes#97740: Release reserved GCE IP address after ensure completes.
Signed-off-by: pacoxu <paco.xu@daocloud.io>
…-of-#97625-upstream-release-1.20 automated-cherry-pick-of-kubernetes#97625: use default unkown sock for kubeadm cmd if cri detect is not needed
…quota cherry-pick part of kubernetes#97451: fix counting error in service/nodeport/loadbalancer quota check
…ry-pick-of-#97860-upstream-release-1.20 Automated cherry pick of kubernetes#97860: move all variables in sampleAndWaterMarkHistograms::innerSet
…k-of-#97206-upstream-release-1.20 Automated cherry pick of kubernetes#97206: clean up executing request on panic
MHBauer
force-pushed
the
probe-timeouts
branch
from
2dcab7e to
96b9c22
Compare
remove initial delay milliseconds.
mikebrow
pushed a commit
that referenced
this pull request
Nov 28, 2023
These were found with a modified klog that enables "go vet" to check klog call
parameters:
cmd/kubeadm/app/features/features.go:149:4: printf: k8s.io/klog/v2.Warningf format %t has arg v of wrong type string (govet)
klog.Warningf("Setting deprecated feature gate %s=%t. It will be removed in a future release.", k, v)
test/images/sample-device-plugin/sampledeviceplugin.go:147:5: printf: k8s.io/klog/v2.Errorf does not support error-wrapping directive %w (govet)
klog.Errorf("error: %w", err)
test/images/sample-device-plugin/sampledeviceplugin.go:155:3: printf: k8s.io/klog/v2.Errorf does not support error-wrapping directive %w (govet)
klog.Errorf("Failed to add watch to %q: %w", triggerPath, err)
staging/src/k8s.io/code-generator/cmd/prerelease-lifecycle-gen/prerelease-lifecycle-generators/status.go:207:5: printf: k8s.io/klog/v2.Fatalf does not support error-wrapping directive %w (govet)
klog.Fatalf("Package %v: unsupported %s value: %q :%w", i, tagEnabledName, ptag.value, err)
staging/src/k8s.io/legacy-cloud-providers/vsphere/nodemanager.go:286:3: printf: (k8s.io/klog/v2.Verbose).Infof format %s reads arg #1, but call has 0 args (govet)
klog.V(4).Infof("Node %s missing in vSphere cloud provider cache, trying node informer")
staging/src/k8s.io/legacy-cloud-providers/vsphere/nodemanager.go:302:3: printf: (k8s.io/klog/v2.Verbose).Infof format %s reads arg #1, but call has 0 args (govet)
klog.V(4).Infof("Node %s missing in vSphere cloud provider caches, trying the API server")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trying out morgan's timeout commits here