Skip to content

Conversation

@ahorek
Copy link
Contributor

@ahorek ahorek commented Dec 19, 2018

not a good idea, nil check should be enough

@jeremy
Copy link
Collaborator

jeremy commented Dec 19, 2018

Believe this is meant to catch parsing errors. Agree that blanket rescue nil is too broad, though. We can be more precise.

@ahorek
Copy link
Contributor Author

ahorek commented Dec 19, 2018

I tested this change with 3 test suites (mail, actionmailer and redmine) wihout any regression. These methods aren't responsible for parsing, it should be just a lookup. Rescuing StandardError is too cautious, but well, still better than rescue Exception 😈

@ahorek
Copy link
Contributor Author

ahorek commented Dec 3, 2022

rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants