Skip to content

Add Health command for security assessment and vault hygiene checks#7

Merged
mikeleppane merged 1 commit into
mainfrom
feat/implement-healt-dashboard
Aug 14, 2025
Merged

Add Health command for security assessment and vault hygiene checks#7
mikeleppane merged 1 commit into
mainfrom
feat/implement-healt-dashboard

Conversation

@mikeleppane
Copy link
Copy Markdown
Owner

  • Introduced the Health command to analyze vault security, detecting weak, reused, short, common, and old passwords.
  • Implemented handle_health_command to evaluate vaults and calculate a security score with detailed issue breakdowns and recommendations.
  • Replaced anyhow with color-eyre for enhanced error handling across the workspace.
  • Updated imports and error messages to use eyre for consistency.

Description

Fixes # (issue)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Code refactoring
  • Test improvement
  • CI/CD improvement
  • Other (please describe):

How Has This Been Tested?

  • Unit tests pass locally with cargo test
  • Integration tests pass
  • Manual testing completed
  • Tested on Linux
  • Tested on macOS
  • Tested on Windows

Test Configuration:

  • Rust version:
  • OS:
  • Terminal:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have run cargo fmt to format my code
  • I have run cargo clippy -- -D warnings and addressed all issues
  • I have updated the CHANGELOG.md file (if applicable)

Screenshots / Terminal Output

Screenshots
Terminal Output
<!-- Add terminal output here -->

Performance Impact

  • This change has no performance impact
  • This change improves performance
  • This change may degrade performance

Breaking Changes

  • This change is backwards compatible
  • This change requires migration steps

Additional Context

Related Issues / PRs

  • Related to #
  • Depends on #
  • Blocks #

Reviewer Notes


For Maintainers

  • Changes are covered by tests
  • Documentation has been updated
  • CHANGELOG.md has been updated (if needed)
  • Performance impact has been considered
  • Security implications have been reviewed
  • Cross-platform compatibility verified

- Introduced the `Health` command to analyze vault security, detecting weak, reused, short, common, and old passwords.
- Implemented `handle_health_command` to evaluate vaults and calculate a security score with detailed issue breakdowns and recommendations.
- Replaced `anyhow` with `color-eyre` for enhanced error handling across the workspace.
- Updated imports and error messages to use `eyre` for consistency.
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 14, 2025

Codecov Report

❌ Patch coverage is 16.94352% with 250 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.89%. Comparing base (31b16b5) to head (c8cbac3).
⚠️ Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
crates/cli/src/health.rs 0.00% 196 Missing ⚠️
crates/cli/src/lib.rs 3.22% 30 Missing ⚠️
crates/ui/src/app.rs 0.00% 12 Missing ⚠️
crates/vault/src/lib.rs 75.00% 3 Missing ⚠️
crates/vault/src/registry.rs 62.50% 3 Missing ⚠️
crates/cli/src/utils.rs 60.00% 2 Missing ⚠️
crates/backup/src/manager.rs 80.00% 1 Missing ⚠️
crates/chamber/src/main.rs 0.00% 1 Missing ⚠️
crates/import-export/src/lib.rs 83.33% 1 Missing ⚠️
crates/password-gen/src/lib.rs 80.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
- Coverage   55.29%   53.89%   -1.41%     
==========================================
  Files          16       17       +1     
  Lines        8078     8283     +205     
==========================================
- Hits         4467     4464       -3     
- Misses       3611     3819     +208     
Files with missing lines Coverage Δ
crates/ui/src/ui.rs 0.00% <ø> (ø)
crates/vault/src/crypto.rs 100.00% <100.00%> (ø)
crates/vault/src/db.rs 97.84% <100.00%> (ø)
crates/vault/src/manager.rs 95.92% <100.00%> (ø)
crates/backup/src/manager.rs 95.31% <80.00%> (ø)
crates/chamber/src/main.rs 0.00% <0.00%> (ø)
crates/import-export/src/lib.rs 97.25% <83.33%> (-0.02%) ⬇️
crates/password-gen/src/lib.rs 96.44% <80.00%> (ø)
crates/cli/src/utils.rs 98.76% <60.00%> (ø)
crates/vault/src/lib.rs 75.91% <75.00%> (ø)
... and 4 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31b16b5...c8cbac3. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Aug 14, 2025

CodSpeed Performance Report

Merging #7 will create unknown performance changes

Comparing feat/implement-healt-dashboard (c8cbac3) with main (31b16b5)

Summary

⚠️ No benchmarks were detected in both the base of the PR and the PR.\

@mikeleppane mikeleppane merged commit e5c1e76 into main Aug 14, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants