Skip to content

Fix(undo redo)/delete source folder after undo#7

Merged
mikeleppane merged 1 commit into
mainfrom
fix(undo-redo)/delete-source-folder-after-undo
Jul 24, 2025
Merged

Fix(undo redo)/delete source folder after undo#7
mikeleppane merged 1 commit into
mainfrom
fix(undo-redo)/delete-source-folder-after-undo

Conversation

@mikeleppane
Copy link
Copy Markdown
Owner

Description

Fixes # (issue)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Code refactoring
  • Test improvement
  • CI/CD improvement
  • Other (please describe):

How Has This Been Tested?

  • Unit tests pass locally with cargo test
  • Integration tests pass
  • Manual testing completed
  • Tested on Linux
  • Tested on macOS
  • Tested on Windows

Test Configuration:

  • Rust version:
  • OS:
  • Terminal:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have run cargo fmt to format my code
  • I have run cargo clippy -- -D warnings and addressed all issues
  • I have updated the CHANGELOG.md file (if applicable)

Screenshots / Terminal Output

Screenshots
Terminal Output
<!-- Add terminal output here -->

Performance Impact

  • This change has no performance impact
  • This change improves performance
  • This change may degrade performance

Breaking Changes

  • This change is backwards compatible
  • This change requires migration steps

Additional Context

Related Issues / PRs

  • Related to #
  • Depends on #
  • Blocks #

Reviewer Notes


For Maintainers

  • Changes are covered by tests
  • Documentation has been updated
  • CHANGELOG.md has been updated (if needed)
  • Performance impact has been considered
  • Security implications have been reviewed
  • Cross-platform compatibility verified

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jul 24, 2025

CodSpeed Performance Report

Merging #7 will create unknown performance changes

Comparing fix(undo-redo)/delete-source-folder-after-undo (055e9d4) with main (f9ed9b9)

Summary

⚠️ No benchmarks were detected in both the base of the PR and the PR.\

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 88.83495% with 23 lines in your changes missing coverage. Please review.

Project coverage is 56.51%. Comparing base (f9ed9b9) to head (80f9807).

Files with missing lines Patch % Lines
src/core/undo_manager.rs 88.83% 23 Missing ⚠️

❌ Your project status has failed because the head coverage (56.51%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   55.74%   56.51%   +0.76%     
==========================================
  Files          29       29              
  Lines        8386     8589     +203     
==========================================
+ Hits         4675     4854     +179     
- Misses       3711     3735      +24     
Files with missing lines Coverage Δ
src/core/undo_manager.rs 78.67% <88.83%> (+4.03%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9ed9b9...80f9807. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mikeleppane mikeleppane force-pushed the fix(undo-redo)/delete-source-folder-after-undo branch from 80f9807 to 055e9d4 Compare July 24, 2025 15:53
@mikeleppane mikeleppane merged commit e29173d into main Jul 24, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants