Lots of small pyflakes and PEP-8 cleanups & some simplifications.

[terrycojones]

These are all pretty minor, to make the code 100% clean under both PEP-8 and pyflakes. There are also a few simplifications that I hope wont break anything :-)

[scanny]

Hi Terry, apologies, I won't be able to commit this as-is.

The main problem is that this version is legacy code now and won't be seeing significant new development. Also its test coverage is spotty so there's no real safety net.

The main objective now is to keep it stable for the sake of the many folks who have dependencies on it. So the risk of introducing a lot of changes just doesn't have the benefit to justify the risk.

I don't know what the typical practice is on GitHub, but I think a wise course is to check with the project team first to see how open a project is to accepting pulls. I feel badly that we can't incorporate your work. I hope they are changes you were making to your own fork anyway :)

Sorry I didn't have better news for you.

[mikemaccana]

Sorry Terry, we should have made the changeover more obvious. I've hopefully sorted that out now.

[terrycojones]

Hey, no problem at all. It was just some quick changes to possibly help out

• I shouldn't have done so many things in one brach, and if I'd cared about
  the possible waste of time I'd have asked in advance. So it's all fine!
  Thanks for putting the code out there in the first place :-)

On Tue, Feb 18, 2014 at 12:09 PM, Mike MacCana notifications@github.comwrote:

Sorry Terry, we should have made the changeover more obvious. I've
hopefully sorted that out now.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/61#issuecomment-35373883
.