SQLAlchemy support #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* each filter backend now defines which lookups it supports which each individual filter honors. this change allows for other filter backends with slightly different lookups support. even in DjangoFilterBackend, support for "search" lookup was removed since its only MySQL supported. * DRF integration now validates that the queryset and filterset models match just before filtering. the reason is that now filter backend extracts a model from the queryset. that is necessary since since we can't assume that queryset.model will work across other filtering sources such as SQLAlchemy.
that allows to use SQLAlchemy to query data from db in addition to using Django ORM. this will be used by the upcoming SQLAlchemy support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial work for SQLAlchemy support.
closes #2, #5 and #7