Skip to content
This repository was archived by the owner on Apr 21, 2024. It is now read-only.

(@mikojs/react-cms) Fix error #459

Merged
HsuTing merged 8 commits into from
Nov 6, 2019
Merged

(@mikojs/react-cms) Fix error #459

HsuTing merged 8 commits into from
Nov 6, 2019

Conversation

@HsuTing
Copy link
Contributor

@HsuTing HsuTing commented Nov 4, 2019 •
edited
Loading

Rewrite
https://github.com/mikojs/core/tree/1c2347b39ad970347381141d89d059d0ca48d5ab/components/react-dnd/src

TODO

  • Fix hook name
  • Fix render too many times
  • Fix render error
  • check update times with updateSource

@HsuTing HsuTing added the PR: Bug Fix 🐛 Something isn't working label Nov 4, 2019
@HsuTing HsuTing added this to the 2.0.0 milestone Nov 4, 2019
@HsuTing HsuTing self-assigned this Nov 4, 2019
HsuTing
HsuTing commented Nov 5, 2019
View reviewed changes
Copy link
Contributor Author

@HsuTing HsuTing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Fix hook name
  • Fix render too many times

@HsuTing HsuTing merged commit 39754ba into master Nov 6, 2019
@HsuTing HsuTing deleted the fix-error branch November 6, 2019 05:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@HsuTing HsuTing

Labels

PR: Bug Fix 🐛 Something isn't working

Projects

None yet

Milestone

2.0.0-deprecated

Development

Successfully merging this pull request may close these issues.

2 participants

@HsuTing