Merge v4-beta into v4 (2026-06-03)

[xnacly]

Fast-forward merge of v4-beta into v4. Includes PR #177 (Setup MSVC Dev Cmd step on Windows runners in node-matrix workflows).

Automated branch created by 0-merge-beta.yaml; the PR step in that workflow failed with "Resource not accessible by integration" so opening manually.

Greptile Summary

This PR fast-forwards v4-beta into v4, bringing in PR #177 which adds a "Setup MSVC Dev Cmd" step to both node-matrix.yaml and node-matrix-pnpm.yaml. The step activates the MSVC developer environment on Windows runners so that subsequent native C/C++ compilation steps (e.g. pip wheel against a setuptools sdist) can locate cl.exe and the SDK headers.

• Adds an identical Setup MSVC Dev Cmd step to both node-matrix workflow files, guarded by if: runner.os == 'Windows', using the repo-internal setup-msvc-dev-cmd action (which in turn pins ilammy/msvc-dev-cmd to a specific commit hash).
• The arch input is derived from matrix.arch: arm64 maps to arm64 and everything else falls back to amd64, which correctly covers the amd64/arm64 values used in the default matrix definition.
• The step is inserted before ccache configuration and Node.js environment setup, ensuring the MSVC toolchain is available for all native build steps that follow.

Confidence Score: 5/5

The change is a focused, additive Windows-only step with a clear conditional guard, no impact on non-Windows runners, and no modifications to existing logic.

Both workflows receive identical, well-scoped additions. The underlying action pins ilammy/msvc-dev-cmd to a specific commit hash, the arch mapping covers all matrix values actually in use (amd64 and arm64), and placement before ccache/node preparation is correct. No existing steps are modified.

No files require special attention.

Important Files Changed

Filename	Overview
.github/workflows/node-matrix.yaml	Adds a "Setup MSVC Dev Cmd" step (Windows-only) before ccache/node preparation; arch mapping correctly handles the amd64/arm64 values defined in the default matrix.
.github/workflows/node-matrix-pnpm.yaml	Mirrors the identical MSVC Dev Cmd step addition from node-matrix.yaml; inserted at the correct position (after macOS pipx install, before ccache).

Sequence Diagram

sequenceDiagram
    participant Runner as Windows Runner
    participant MSVC as setup-msvc-dev-cmd@v4
    participant ilammy as ilammy/msvc-dev-cmd (pinned)
    participant ccache as Configure ccache
    participant node as Node / pnpm prepare
    participant build as Native C/C++ build steps

    Runner->>MSVC: "if runner.os == 'Windows'"
    MSVC->>ilammy: "arch = (matrix.arch == 'arm64' ? 'arm64' : 'amd64')"
    ilammy-->>Runner: vcvarsall.bat sourced (cl.exe, SDK headers on PATH)
    Runner->>ccache: Configure ccache (if enabled)
    Runner->>node: Prepare Node environment
    Runner->>build: pip wheel / native extensions (cl.exe available)

Loading

_{Reviews (1): Last reviewed commit: "Merge pull request #177 from milaborator..." | Re-trigger Greptile}