Skip to content

v4.1 #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miladrahimi merged 5 commits into from
Nov 3, 2019
Merged

v4.1 #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
acc2054
move route to values ns
miladrahimi Nov 3, 2019
0bc6aec
add empty line to the end of the file
miladrahimi Nov 3, 2019
2339e49
update phpunit.xml
miladrahimi Nov 3, 2019
e703811
update composer.json
miladrahimi Nov 3, 2019
1fe2c74
bring the emptylines back
miladrahimi Nov 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 15 additions & 20 deletions phpunit.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,16 @@
<phpunit
backupGlobals="false"
colors="true"
convertErrorsToExceptions="true"
convertNoticesToExceptions="true"
convertWarningsToExceptions="true"
>
<testsuites>
<testsuite name="main">
<directory>./tests</directory>
</testsuite>
</testsuites>
<filter>
<whitelist processUncoveredFilesFromWhitelist="true">
<phpunit backupGlobals="false" colors="true" convertErrorsToExceptions="true" convertNoticesToExceptions="true"
convertWarningsToExceptions="true">
<testsuites>
<testsuite name="main">
<directory>./tests</directory>
</testsuite>
</testsuites>
<filter>
<whitelist processUncoveredFilesFromWhitelist="true">
<directory suffix=".php">./src</directory>
</whitelist>
</filter>
<logging>
<log type="coverage-clover" target="build/logs/clover.xml"/>
</logging>
</phpunit>
</whitelist>
</filter>
<logging>
<log type="coverage-clover" target="build/logs/clover.xml"/>
</logging>
</phpunit>
1 change: 1 addition & 0 deletions src/Router.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
use MiladRahimi\PhpRouter\Exceptions\RouteNotFoundException;
use MiladRahimi\PhpRouter\Services\HttpPublisher;
use MiladRahimi\PhpRouter\Services\PublisherInterface;
use MiladRahimi\PhpRouter\Values\Route;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use ReflectionException;
Expand Down
2 changes: 1 addition & 1 deletion src/Route.php → src/Values/Route.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

namespace MiladRahimi\PhpRouter;
namespace MiladRahimi\PhpRouter\Values;

/**
* Class Route
Expand Down
2 changes: 1 addition & 1 deletion test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
./vendor/bin/phpunit --coverage-text --coverage-html build/html ./tests
./vendor/bin/phpunit --coverage-text --coverage-html build/html ./tests