fix #149 rename .pde examples to .ino #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added example timing.ino, measures timing at different resolutions
…ces. Other onewire devices may not support these calls.
- Corrected library references from DS28B20 to DallasTemperature - Corrected reference to library version (text and constant) - Replaced call to getTempC() to getTempCByIndex(0) - Changed Serial baudrate to 9600 like other example files - Removed loop to wait for isConversionComplete() (library checks this) - Corrected filename comment to Timing.ino - Updated version info in comment
Updated timing example
Delegating constructor to avoid duplicate code.
Discussed in issue #110
Change timeout when blocking till conversion is complete
This was referenced Feb 21, 2020
milesburton
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added example timing.ino, measures timing at different resolutions