fix: retry right-click context menu for flaky GWT interactions#26
Merged
fix: retry right-click context menu for flaky GWT interactions#26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a retry loop (up to 3 attempts) around the right-click → context menu detection in all three commands that use it: quick-add, log-food, and add-custom-food. Between retries, dismisses stale state with Escape + click-away and waits 1s for the GWT app to stabilize.
Why
Cronometer's GWT-based UI intermittently fails to show the context menu after a right-click, causing
quick-add(and other commands) to fail with "Context menu did not appear after right-clicking". A single retry attempt is insufficient for a flaky UI interaction — 3 attempts with cleanup between each makes this robust.Ref
Reported via CLI:
crono quick-add -p 1 --meal Dinner→ "Context menu did not appear after right-clicking Dinner"