fix: fall back to ls-remote when origin/HEAD is unset in skip check#17
Merged
fix: fall back to ls-remote when origin/HEAD is unset in skip check#17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
git ls-remote --symref origin HEADas a fallback in the default status spec's skip check whengit symbolic-ref refs/remotes/origin/HEADfails.Why
In flow worktrees,
origin/HEADis not always set as a symbolic ref (depends on how the bare clone was created). When it's missing, the skip check silently fails, causing repos on their default branch (e.g.main) to not be skipped. This drags the workspace status down toopeneven when all feature-branch PRs are merged.Ref
Observed on the
atmos-pro-idor-vulernabilityworkspace which showedopendespite all PRs being merged — theatmos-pro-qa-2repo onmainwasn't being skipped.