Conversation
- Remove /api/estimate-score route; nothing in this repo (CLI, react-doctor package, or website) calls it. The only score endpoint actually used by the CLI is /api/score. - Halve TYPING_DELAY_MS (50ms -> 25ms) so the command types in noticeably faster. - Tighten the diagnostic stagger window (150-350ms -> 60-140ms) so the React Doctor findings reveal more snappily. Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Halve the inter-section pauses so the demo flows more snappily without losing the rhythm between phases: - INITIAL_DELAY_MS: 500 -> 250 (pre-typing) - PROJECT_SCAN_DELAY_MS: 800 -> 350 (after command finishes typing) - POST_HEADER_DELAY_MS: 600 -> 250 (after react-doctor header) - SCORE_REVEAL_DELAY_MS: 600 -> 250 (between findings and score) - POST_SCORE_DELAY_MS: 700 -> 300 (between score and summary CTA) Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Polish + cleanup pass on the marketing site.
1. Delete dead code
Removed
packages/website/src/app/api/estimate-score/route.ts. Nothing in the repo (CLI,react-doctorpackage, or website) calls/api/estimate-score— the CLI only ever talks to/api/score(SCORE_API_URLinpackages/react-doctor/src/constants.ts). The estimate endpoint duplicated the scoring/validation logic of/api/scoreand was unreachable from any client surface.A wider sweep of the website (
page.tsx,terminal.tsx,share/*,share/badge,share/og,install-skill,globals.css, public assets) didn't turn up other clearly-dead modules — the share/badge/og routes are all reachable from the CLI'sbuildShareUrl, and the install-skill route is intentionally kept forcurl | bashinstalls.2. Faster typing in the terminal demo
TYPING_DELAY_MS:50→25. Thenpx -y react-doctor@latest .command now types in roughly half the time.3. Quicker diagnostic stagger
DIAGNOSTIC_MIN_DELAY_MS/DIAGNOSTIC_MAX_DELAY_MS:150–350→60–140. The React Doctor findings still reveal one-by-one with a small randomized cadence, but the whole list lands much faster.4. Tighter inter-section delays
The pauses between phases were the slowest part of the demo. Roughly halved:
INITIAL_DELAY_MS:500→250(pre-typing)PROJECT_SCAN_DELAY_MS:800→350(after the command finishes typing)POST_HEADER_DELAY_MS:600→250(after thereact-doctorheader)SCORE_REVEAL_DELAY_MS:600→250(between findings and score reveal)POST_SCORE_DELAY_MS:700→300(between score and the CTA summary)The animation still has natural breathing room between phases, but it gets to the score and CTA roughly twice as fast end-to-end.
Verification
pnpm lint✅pnpm typecheck✅ (also rantsc --noEmitdirectly insidepackages/website)pnpm format:check✅pnpm test✅ (619 tests pass)