fix(website): keep diagnostic count next to rule name on narrow widths#181
Merged
Conversation
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the website's terminal demo, the per-rule occurrence counts (
×5,×12, etc.) appear to "float" on their own row, far away from the rule name they belong to, on narrow viewports (mobile).The cause: rule names were padded to a fixed 42-char column with non-breaking spaces so the counts visually right-aligned into a column. When the rule name itself wrapped on a narrow screen, that long run of non-breaking spaces pushed the count to the right edge of a new line, creating the floating effect.
Fix
padRuleName/RULE_NAME_COLUMN_WIDTH).The desktop terminal aesthetic is preserved (count still flows inline after the rule name), and on mobile the count now stays glued to the rule name instead of being shoved to the right edge.