Fix Node 20 runtime dependency support#469
Merged
Merged
Conversation
Avoid the Node 22-only Undici dependency path while keeping Effect platform services and package builds aligned with the supported Node range.
|
✅ No new issues Reviewed by reactreview for commit 2e21cb7. Configure here. |
Run version-matrix tests across supported Node releases while keeping TS-config-dependent quality checks on a compatible Node version.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 98c7240. Configure here.
Quote Node matrix versions so conditional quality steps match the intended runtime exactly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@effect/platform-nodewith@effect/platform-node-sharedso React Doctor no longer installsundici@8, which requires Node 22.19+.Config.redactedwhile switching the HTTP client layer toFetchHttpClient.node20and add metadata tests that guard Node engine/build/dependency compatibility.Test plan
nr format:checknr typechecknr testnr lintNote
Low Risk
Workflow-only YAML change with no application runtime or dependency impact.
Overview
The CI test matrix now declares every
node-versionentry as a string (e.g."20.19.0"and"22.18.0"instead of bare numeric literals).That keeps pinned semver versions from being coerced or misread by Actions/YAML and aligns matrix values with the existing
if: matrix.node-version == '22.18.0'checks, so Node 20.19.0 and other pinned runtimes are exercised reliably in CI.Reviewed by Cursor Bugbot for commit 2e21cb7. Bugbot is set up for automated code reviews on this repo. Configure here.