feat(rules): demote 19 low-signal rules to opt-in

[aidenybai]

Summary

Move 19 low-signal rules out of the default recommended preset via defaultEnabled: false, so a default scan focuses on correctness, performance, accessibility, and security instead of subjective style. Every demoted rule still ships in the plugin and can be re-enabled with a one-line severityControls / config entry.

Demoted to opt-in

• Subjective design / house-style (13): no-gradient-text, no-dark-mode-glow, no-pure-black-background, no-side-tab-border, no-wide-letter-spacing, no-justified-text, no-z-index-9999, design-no-em-dash-in-jsx-text, design-no-three-period-ellipsis, design-no-vague-button-label, design-no-redundant-padding-axes, design-no-redundant-size-axes, design-no-space-on-flex-children
• Naming-convention preferences (2): no-generic-handler-names, jsx-pascal-case
• Legacy class / PropTypes (3): prefer-es6-class, no-default-props, no-prop-types — don't fire in a modern function-component + TypeScript codebase
• Dedupe (1): no-array-index-key — double-reported with the canonical no-array-index-as-key (Bugs category, friendlier message). The port's only unique coverage is React.cloneElement; opt back in if you need it.

Notes

• Each demoted rule carries a short comment explaining why it's off by default.
• collectRuleHits (regression helper) now force-enables the rule under test, so default-disabled rules still produce hits in their own tests. Severity is irrelevant there — callers assert on file path + message.
• Changeset: minor bump (changes the default-enabled rule set), which fans out to the three fixed published packages.

Test plan

• pnpm typecheck — clean
• pnpm lint — clean (only pre-existing fixture warnings)
• Registry regen (pnpm gen) — no diff (the flag flows through the rule spread)
• react-19-migration-rules, react-ui-rules, rules-command, terminal-visuals — pass
• Core metadata tests (build-rule-docs-url, has-published-fix-recipe, dead-code-may-surface) — pass
• CI green

Note: one pre-existing no-array-index-key rule-tester case (key={1 + index}) fails on clean main as well — unrelated to this change.

---

Note

Medium Risk
Upgrading changes which diagnostics appear without config (preset behavior), though every rule remains one-line re-enableable and no runtime app logic changes.

Overview
Nineteen react-doctor rules are opt-in by default (defaultEnabled: false), so the built-in recommended preset runs fewer warnings out of the box and emphasizes correctness, performance, accessibility, and security over style and legacy patterns.

The demoted set covers subjective design / copy / Tailwind house style (e.g. gradient text, pure black backgrounds, em dashes, redundant px/py), naming tastes (jsx-pascal-case, no-generic-handler-names), legacy React 19 migration nags (defaultProps, propTypes, prefer-es6-class), and no-array-index-key to avoid double-reporting with no-array-index-as-key (still available for React.cloneElement if opted in). Each rule file documents why it is off by default; a minor changeset records the preset change for oxlint-plugin-react-doctor.

Tests: collectRuleHits always enables the rule under test via userConfig, and inspect surface-filter tests opt a few design rules back in so design-tag filtering still has real diagnostics to assert on.

^{Reviewed by Cursor Bugbot for commit 5ffbc9f. Bugbot is set up for automated code reviews on this repo. Configure here.}

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/eslint-plugin-react-doctor@644

npm i https://pkg.pr.new/oxlint-plugin-react-doctor@644

npm i https://pkg.pr.new/react-doctor@644

commit: 5ffbc9f

[github-actions]

React Doctor found 22 files changed in this pull request, but none matched the files covered by its enabled checks.

Scope: 22 files changed on chore/opt-out-low-value-default-rules vs. main.

View workflow run

Generated by React Doctor. Questions? Contact founders@million.dev.