fix: show new billing accounts in the activity feed#67
Merged
Conversation
The BillingAccount create-fallback activity rule linked
audit.objectRef.name, which is empty for generateName-created accounts.
CEL summary evaluation then errored ("no such key: name"), the activity
entry was dead-lettered, and the create never appeared in the activity
feed. Two production failures were observed (error_type=cel_summary).
Switch the linked label to audit.responseObject.metadata.name, which is
populated for both name and generateName creates, while keeping
audit.objectRef as the link target. Apply the same swap preventively to
the BillingAccountBinding create-fallback rule, which shares the
unguarded pattern (no production failures observed).
Update and delete rules are untouched: audit.objectRef.name is reliably
present there.
Claude-Session: https://claude.ai/code/session_01KnYuL5Pf1R5ysZoxxNkKiu
scotwells
changed the title
scotwells
requested review from
JoseSzycho,
ecv,
kevwilliams,
mattdjenkinson,
privateip and
savme
mattdjenkinson
approved these changes
Jun 25, 2026
ecv
approved these changes
Jun 25, 2026
This was referenced Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
When a billing account is created, it should appear in the activity feed — but in some cases that entry was quietly going missing. This makes new billing accounts show up reliably, and applies the same fix to billing account bindings so they don't hit it either.
What changed