fix(services): exclude activity from default aggregate#605
Merged
Conversation
ActivityPolicy resources require the activity.miloapis.com CRDs, which are not installed by the milo control plane bootstrap. Including config/services/activity in the default config/services aggregate caused the test-environment-validation job to fail on every PR with: resource mapping not found ... no matches for kind "ActivityPolicy" in version "activity.miloapis.com/v1alpha1" ensure CRDs are installed first config/services/activity/kustomization.yaml already documents that this component should be applied separately once the activity service is present, but the aggregate kept pulling it in regardless. Anyone needing ActivityPolicies should apply config/services/activity/ explicitly after ensuring the activity CRDs are installed.
Contributor
scotwells
approved these changes
May 6, 2026
Contributor
scotwells
left a comment
scotwells
left a comment
There was a problem hiding this comment.
You'll want a corresponding change on the infra side to enable this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove
activityfrom the defaultconfig/services/kustomization.yamlaggregate so itsActivityPolicyresources aren't applied to clusters that don't have theactivity.miloapis.comCRDs installed.Why
PR #579 added 23
ActivityPolicyresources underconfig/services/activity/policies/...and wiredactivityinto the top-levelconfig/services/kustomization.yaml, but theActivityPolicyCRD is not part of the milo control plane bootstrap. As a result, every PR'stest-environment-validationjob fails whentask dev:deployrunskubectl apply -k config/services/:config/services/activity/kustomization.yamlalready explicitly documents that this component should be applied separately once the activity service is present:But the aggregate kept pulling it in regardless. This change makes the comment match the behavior.
Behavior change
kustomize build config/services/no longer emitsActivityPolicyresources (verified: 0 emitted, was 23).kustomize build config/services/activity/still emits all 23ActivityPolicyresources for environments that need them.ActivityPolicyCRD.Test plan
kustomize build config/services/ | grep -c ActivityPolicy→0kustomize build config/services/activity/ | grep -c ActivityPolicy→23test-environment-validationjob passes on this PR