Skip to content

fix: peer connect panic on log#2272

Merged
garyyu merged 1 commit intomimblewimble:masterfrom
garyyu:peer-connect-panic
Jan 2, 2019
Merged

fix: peer connect panic on log#2272
garyyu merged 1 commit intomimblewimble:masterfrom
garyyu:peer-connect-panic

Conversation

@garyyu
Copy link
Contributor

@garyyu garyyu commented Jan 2, 2019

Two reports in Gitter lobby on this panic error:

thread 'peer_connect' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 107, kind: NotConnected, message: "Transport endpoint is not connected" }': libcore/result.rs:1009stack backtrace:

I got the log file and find 97 such panic errors in 24 hours.

I guess the related code is:

		debug!("connect: handshaking with {:?}", conn.peer_addr().unwrap());

which is just imported in a recent PR.

So, let's remove that unwrap().

@garyyu garyyu merged commit 7e8296d into mimblewimble:master Jan 2, 2019
@garyyu garyyu deleted the peer-connect-panic branch January 3, 2019 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant