feat: Configuration option to include foreign API endpoints in the owner API#2305
Merged
yeastplume merged 2 commits intomimblewimble:masterfrom Jan 7, 2019
Merged
Conversation
hashmap
approved these changes
Jan 7, 2019
Member
|
Looks good to me, and thanks for submitting this. Appreciate very much that you've also included tests and additions to documentation where necessary. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds an
owner_api_include_foreignwallet configuration option to make endpoints from the Foreign API available over the same port as the Owner API.A few notes on the actual change:
/v1/wallet/foreignand the Owner API endpoints start with/v1/wallet/owner/.I have added a basic integration test to make sure setting the configuration option on/off works as expected. This involved making some changes to the test harness, so I've separated the changes for the tests into a separate commit in case those changes are problematic.
This is my first PR to this repository, so as usual please let me know if I'm missing anything major from the PR or description. Thanks!