Feedback #1
Open
Feedback #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agluszak
requested changes
Apr 28, 2022
README.md
Outdated
| ## Biblioteki | ||
| - Bevy | ||
| - może coś do serializacji danych? (czy mógłby Pan coś polecić?) | ||
| Projekt aplikacji chatu napisanej w języku Rust, |
There was a problem hiding this comment.
Przydałoby się coś więcej powiedzieć...
- added framerate limiter to address issue of excessive CPU usage
- Message "packet" length is no longer fixed to 512 bytes - Message "packet" length is now dynamic (must not be longer than 65535 bytes) More details: Message is no longer sent as fixed-size 512 byte stream consisting of JSON padded with trailing zeros. Instead primitive Header-Body approach is used, server sends Header, then Body. Header is u16 integer representing Body size in bytes (hence 2^16-1 size limit) Body is JSON containing message sender, text, timestamp etc.
New client prototype
Project merged into one cargo workspace (updated `.gitignore` accordingly) Divided source files into multiple ones (Both `client` and `server`) Now both `server` and `client` are using more json and less raw data in communication (last raw data are used in Client->Server communication) Removed unnecessary dependencies Completely new client approach, much less resource-intensive than previous version, more terminal-friendly Message size limit raised to 256 characters (still can be raised up by increasing `MESSAGE_MAX_LENGTH` const in client `main.rs` file) Known issue - New client introduced some unwanted behavior when resizing console (specifically decreasing width)
Code tidy-up
fixed dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
mainsince the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips: - Click the **Files changed** tab to see all of the changes pushed to `main` since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue **+** (plus sign). To learn more about comments, read “[Commenting on a pull request](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/commenting-on-a-pull-request)”. - Click the **Commits** tab to see the commits pushed to `main`. Click a commit to see specific changes. - If you turned on autograding, then click the **Checks** tab to see the results. - This page is an overview. It shows commits, line comments, and general comments. You can leave a general comment below. For more information about this pull request, read “[Leaving assignment feedback in GitHub](https://docs.github.com/education/manage-coursework-with-github-classroom/leave-feedback-with-pull-requests)”.Subscribed: @grzenow4