Feedback #1
Feedback #1
Conversation
Wstępny opis projektu
Small updates after conversation about project during classes.
…displayed messages, modified UI (for sudoku).
…almost finished, needs updated README.md and detailed comments.
…ote about the populate() function.
There was a problem hiding this comment.
Bardzo ładnie, kod elegancki, feature'y się zgadzają. W drugiej części będę prosił o napisanie testów. Przynajmniej jeden unit test (np. dla generatora sudoku) i przynajmniej jeden test UI (https://developer.android.com/develop/ui/compose/testing)
5/5
| // (in a separate module for demo project and in testMain). | ||
| // With compose.desktop.common you will also lose @Preview functionality | ||
| implementation(compose.desktop.currentOs) | ||
| implementation("org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.8") |
| implementation("org.jetbrains.exposed:exposed-core:0.41.1") | ||
| implementation("org.jetbrains.exposed:exposed-dao:0.41.1") | ||
| implementation("org.jetbrains.exposed:exposed-jdbc:0.41.1") | ||
| implementation("org.xerial:sqlite-jdbc:3.42.0.0") | ||
| implementation("org.jetbrains.kotlinx:kotlinx-coroutines-core:1.7.0") | ||
| implementation("org.jetbrains.kotlinx:kotlinx-serialization-json:1.6.0") |
| import com.app.ui.screens.games.MastermindScreen | ||
| import com.app.ui.screens.games.TicTacToeScreen | ||
| enum class Game { | ||
| MENU, SUDOKU, MASTERMIND, TIC_TAC_TOE |
| selectedCell?.let { (x, y) -> | ||
| if (selectedNumber != null) { | ||
| scope.launch { | ||
| val updatedBoard = updateCell(board, x, y, selectedNumber!!) |
There was a problem hiding this comment.
selectedNumber można przypisać do jakiegoś vala i wtedy po sprawdzeniu != null nie trzeba będzie robić !!
| } | ||
|
|
||
| // Updating board state | ||
| fun updateCell(board: SudokuBoard?, x: Int, y: Int, number: Int): Pair<SudokuBoard, Boolean> { |
There was a problem hiding this comment.
| fun updateCell(board: SudokuBoard?, x: Int, y: Int, number: Int): Pair<SudokuBoard, Boolean> { | |
| fun updateCell(board: SudokuBoard, x: Int, y: Int, number: Int): Pair<SudokuBoard, Boolean> { |
i tak nie obsługuje Pan tutaj przypadku, że board jest nullem
| } | ||
|
|
||
| // Updating board state | ||
| fun updateCell(board: SudokuBoard?, x: Int, y: Int, number: Int): Pair<SudokuBoard, Boolean> { |
There was a problem hiding this comment.
nie wiadomo czym jest bool w parze, dlatego polecam używać data class z nazwanymi polami
|
Z testowania "ręcznego": brakuje mi podświetlenia które liczby wpisał użytkownik (np. innym kolorem), a zapisywanie raczej nie powinno przeładowywać planszy, tylko ew. wyświetlić jakieś powiadomienie |
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to the default branch since the assignment started. Your teacher can see this too.
Notes for teachers
Use this PR to leave feedback. Here are some tips:
For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @kuzmajan