Calling jinx-languages and saving the variable buffer locally looses the point.

[BibleBelt]

When I'm editing in a buffer and call "jinx-languages", the point is lost when the snippet

Local Variables:

jinx-languages: "en_US"

End:

is inserted at the end of the buffer.

This can be avoided easily when the cond form in the function is wrapped in a save-excursion.

(defun jinx-languages (langs &optional global)
...
(interactive (list (jinx--read-languages) current-prefix-arg))
(unless jinx-mode (jinx-mode))
(save-excursion (cond
(global
... )))
(jinx--load-dicts)
(jinx--cleanup))

Is this a worthwhile change, or is moving the point to the location where the local variable is defined on purpose?

[minad]

I guess it is fine as is. We rely on the command add-file-local-variable, and this moves point. Maybe add-file-local-variable should itself be changed to preserve the original position? But my assumption is that this is intentional, such that the user see where the file local variable was added.

[BibleBelt]

Ok, fine. I agree that for add-file-local-variable it makes a lot of sense to leave the point where the insertion was done. If some dangerous variables are set, the user should inspect them immediately.

I'll try to find a solution for me. The problem occurred only when I was editing a lot of small files recently in German and English.

If I could only find the proper incantation for advice-add ... ;-).

[BibleBelt]

Ok, to finish this up. I found a way to do what I want with advice-add:

I needed to use funcall to tell the interpreter cmd is a function and I needed to unpack the args from a list into a string with mapconcat.

(defun wrap-with-save-excursion (cmd &rest args)
	(save-excursion (funcall cmd (mapconcat 'identity args " "))))

(advice-add 'jinx-languages :around #'wrap-with-save-excursion)

This stackexchange post was helpful in finding why my initial naive attempt failed.