Please support removing words from the dictionary

[rrthomas]

Please support for removing words from the dictionary and session (enchant_dict_remove & enchant_dict_remove_from_session).

[minad]

Which UI would you expect for this feature? read-string with the word at point as default input? And then remove everywhere (all dictionaries, from file-local, dir-local and buffer local word lists)?

[rrthomas]

Good question, which I deliberately skipped when I opened the discussion!

Your suggestion is good. I guess for completeness I would hope to have the same variants as exist for adding a word; that is, those you've listed. The obvious problem is what UI to offer given that one is not already in "spelling mode" when asking to remove a word. One option would be to make the C-u prefix prompt for whence the word should be removed, while defaulting to all.

The other question, implicit in your suggestion, is how the different levels should stack: adding a word in one place adds it to all "nested" places, so removal should do the same; that is, removing from the file should also remove from the session; removing from the directory should remove from the current file (but maybe not others?), and removing from the personal wordlist should remove from the directory and current file by default. However, there will be situations in which one wants to remove only from a specific location (e.g. I accidentally added a deliberate misspelling in this chapter (=file) of my book to the directory (=book), and I now want to remove it just from the directory).

This suggests to me a set of commands that remove a word in only one place:

jinx-remove-from-session-only
jinx-remove-from-file-only
jinx-remove-from-dir-only
jinx-remove-from-pwl-only

which are then combined to get the "standard" commands:

jinx-remove-from-session = jinx-remove-from-session-only ; alias for completeness
jinx-remove-from-file-only = jinx-remove-from-file-only + jinx-remove-from-session
jinx-remove-from-dir = jinx-remove-from-dir-only + jinx-remove-from-file
jinx-remove = jinx-remove-from-pwl = jinx-remove-from-pwl-only + jinx-remove-from-dir

And then the commands one would bind would be jinx-remove, plus (with prefix argument) a menu that offers jinx-remove-from-pwl (the same thing!), jinx-remove-from-dir, jinx-remove-from-file, and jinx-remove-from-session.

This is a lot of extra functions, but they're simple and uniform; they exist because there's no natural UI (that I can see) to attach the actions to, so each needs its entry point. But there's only one key binding, and the *-only commands are expected to be rarely used, so they're not accessible via keyboard bindings at all by default.

[rrthomas]

I think a two-step process would be better. First ask for the word, and then ask from where to remove it.

* session-only

* dir-local (+ session implicitly)

* file-local (+ session implicitly)

* pwl

Certainly sounds more jinx-y, and as in any case it's likely to be a rare action, I don't think it matters much if it always takes two steps.

[minad]

Implemented in c728b47

[rrthomas]

Wow amazing, I had this on my to-do list for ispell.el for YEARS!

[minad]

It wasn't really on my list, but of course I had noticed the lack of this feature before. I just edited the dictionaries and file local variable variables manually. Took quite a bit of effort to implement this now.

[rrthomas]

Much appreciated!