Use "current-minibuffer-command" in vertico-multiform-commands lookup#663
Closed
matthewbauer wants to merge 1 commit into
Closed
Use "current-minibuffer-command" in vertico-multiform-commands lookup#663matthewbauer wants to merge 1 commit into
matthewbauer wants to merge 1 commit into
Conversation
As mentioned in bug#45392[1], read-from-minibuffer will have this-command = exit-minibuffer, which isn’t very useful for filtering. The alternative is "current-minibuffer-command" which should always have the originating command name. [1]: https://lists.gnu.org/archive/html/bug-gnu-emacs/2021-01/msg01463.html
Owner
|
Thanks for reminding me about current-minibuffer-command. IIrc I had looked into this once in the past. In my test current-minibuffer-command does not give an advantage, it is either nil or the same as this-command. Please open a discussion instead with an example, such that I can understand where it makes a difference for you. |
Author
|
sure: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in bug#453921, read-from-minibuffer will have this-command = exit-minibuffer, which isn’t very useful for filtering. The alternative is "current-minibuffer-command" which should always have the originating command name.