Skip to content

Comments

Lint#1366

Merged
PalmerAL merged 6 commits intominbrowser:masterfrom
Milo123459:lint-4
Dec 4, 2020
Merged

Lint#1366
PalmerAL merged 6 commits intominbrowser:masterfrom
Milo123459:lint-4

Conversation

@Milo123459
Copy link
Member

This just lints JS with standard, css with prettier

Adds command lint

@PalmerAL
Copy link
Collaborator

PalmerAL commented Dec 2, 2020

Files in /ext need to be excluded from formatting because they're imported from external repositories. Other than that, I think everything looks good.

@Milo123459
Copy link
Member Author

Files in /ext need to be excluded from formatting because they're imported from external repositories. Other than that, I think everything looks good.

+1, fixed

@PalmerAL
Copy link
Collaborator

PalmerAL commented Dec 4, 2020

I'm guessing the JS files in /ext would need to be excluded as well; prettierignore only applies to CSS, right?

The existing test command is this:

    "test": "standard --verbose js/**/*.js main/*.js",

So I think you could use the same path arguments for the lint command.

Also, can you revert the formatting changes in the ext directory?

@Milo123459
Copy link
Member Author

The prettierignore ignores CSS linting, as thats what prettier is doing, linting css. I'll update the script, and reverting it might take a bit but I'll get to work.

@Milo123459
Copy link
Member Author

@PalmerAL all fixed, you can go over it if you want

@PalmerAL
Copy link
Collaborator

PalmerAL commented Dec 4, 2020

Looks good to me!

@PalmerAL PalmerAL merged commit a174488 into minbrowser:master Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants