#MBX-2529 Add abtests logic #358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enotniy
force-pushed
the
feature/MBX-2529_1
branch
from
4201284 to
41a445f
Compare
enotniy
force-pushed
the
feature/MBX-2529_2
branch
3 times, most recently
from
0d9d879 to
80a35de
Compare
dbvasilyev
requested changes
Jun 9, 2023
sdk/src/main/java/cloud/mindbox/mobile_sdk/abtests/InAppABTestLogic.kt
Outdated
Show resolved
Hide resolved
sdk/src/main/java/cloud/mindbox/mobile_sdk/abtests/InAppABTestLogic.kt
Outdated
Show resolved
Hide resolved
sdk/src/main/java/cloud/mindbox/mobile_sdk/abtests/InAppABTestLogic.kt
Outdated
Show resolved
Hide resolved
sdk/src/main/java/cloud/mindbox/mobile_sdk/abtests/InAppABTestLogic.kt
Outdated
Show resolved
Hide resolved
sdk/src/main/java/cloud/mindbox/mobile_sdk/abtests/InAppABTestLogic.kt
Outdated
Show resolved
Hide resolved
sdk/src/main/java/cloud/mindbox/mobile_sdk/abtests/InAppABTestLogic.kt
Outdated
Show resolved
Hide resolved
sdk/src/main/java/cloud/mindbox/mobile_sdk/inapp/domain/InAppInteractorImpl.kt
Outdated
Show resolved
Hide resolved
sdk/src/main/java/cloud/mindbox/mobile_sdk/inapp/data/validators/ABTestValidator.kt
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @Test | ||
| fun `abtest logic two variants with inapps1`() = runTest { |
There was a problem hiding this comment.
Не понятно что в тестах в названиях обозначает "with inapps1" "with inapps2"
Давай всем этим тестам дадим названия которые будут описывать какие продуктовые кейсы они проверяют.
Из-за этого к сожалению не могу поревьювить тесты тут.
Collaborator
Author
There was a problem hiding this comment.
у меня есть 2 набора inapp, так же как и в test case есть config1 config2 config3. Как их мне назвать по другому не понятно
enotniy
force-pushed
the
feature/MBX-2529_1
branch
2 times, most recently
from
7e37e9f to
f23a643
Compare
enotniy
force-pushed
the
feature/MBX-2529_2
branch
from
80a35de to
b5d5a1a
Compare
enotniy
force-pushed
the
feature/MBX-2529_1
branch
from
f23a643 to
f12e002
Compare
enotniy
force-pushed
the
feature/MBX-2529_2
branch
from
b5d5a1a to
b5e410d
Compare
enotniy
force-pushed
the
feature/MBX-2529_2
branch
from
5df4f95 to
a5ba178
Compare
dbvasilyev
approved these changes
Jun 13, 2023
enotniy
force-pushed
the
feature/MBX-2529_2
branch
from
a5ba178 to
9f1ac77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавил основную логику abtets и тесты для нее