MBX-2627 get mobile config lazy #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robalim
reviewed
Jun 14, 2023
| val firstLog = monitoringRepository.getFirstLog() | ||
| val lastLog = monitoringRepository.getLastLog() | ||
| mobileConfigRepository.listenMonitoringSection().collect { monitoring -> | ||
| mobileConfigRepository.getMonitoringSection().let { monitoring -> |
Contributor
There was a problem hiding this comment.
Зачем тут let, если возвращается ненуллабельное List ?
И абстрактно, этот пр точно нужен, учитывая, что мы в будущем перейдем на room для хранения конфига?
Collaborator
Author
There was a problem hiding this comment.
нужен, логика не поменяется. поменяется только парсинг, не из prefs а из database
Robalim
reviewed
Jun 14, 2023
| val firstLog = monitoringRepository.getFirstLog() | ||
| val lastLog = monitoringRepository.getLastLog() | ||
| mobileConfigRepository.listenMonitoringSection().collect { monitoring -> | ||
| mobileConfigRepository.getMonitoringSection().let { monitoring -> |
Contributor
There was a problem hiding this comment.
Зачем тут let, если возвращается ненуллабельное List ?
И абстрактно, этот пр точно нужен, учитывая, что мы в будущем перейдем на room для хранения конфига?
Collaborator
Author
There was a problem hiding this comment.
да, не обязательно теперь let
Robalim
approved these changes
Jun 14, 2023
enotniy
force-pushed
the
feature/MBX-2627
branch
from
bca75e6 to
60cc57a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#mindbox-cloud/