[Android] Поддержка таргетинга visit для in-app #3211 #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enotniy
reviewed
Mar 19, 2024
| override fun checkTargeting(data: TargetingData): Boolean { | ||
| val userVisitCount = MindboxPreferences.userVisitCount.toLong() | ||
| return when (kind) { | ||
| KindVisit.GTE -> { |
Collaborator
There was a problem hiding this comment.
Зачем скобки ставить? мне нравится больше когда в одну строку
KindVisit.GTE -> value >= userVisitCount
Contributor
Author
There was a problem hiding this comment.
Я обычно всегда ставлю, на случай, что если придется что-то дописывать, то не пришлось бы их ставить потом. А у нас нет нигде какого-то код стайла, чтобы посмотреть как лучше писать
| is TreeTargetingDto.VisitNodeDto -> { | ||
| !targeting.type.isNullOrBlank() && targeting.kind.equalsAny( | ||
| GREATER_OR_EQUALS, LOWER_OR_EQUALS, EQUALS, NOT_EQUALS | ||
| ) && (targeting.value?.let { it > 0 } == true) |
Collaborator
There was a problem hiding this comment.
согласен что > 0
"value": 1 // required long > 0
enotniy
approved these changes
Mar 19, 2024
| } | ||
|
|
||
| @Test | ||
| fun `validate targeting dto is visit node and its valid with gte`() { |
Collaborator
There was a problem hiding this comment.
Здесь бы получше было что-то такое validate targeting dto return true when is visit node and its valid with gte, но здесь сразу проверка, поэтому тест и так хорошо читается
sergeysozinov
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/mindbox-cloud/issues-web-mobile/issues/3211