MBX-3181: changed order handle click and request permission #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enotniy
reviewed
Apr 17, 2024
| payload = payload, | ||
| shouldDismiss = shouldDismiss() | ||
| shouldDismiss = shouldDismiss(), | ||
| shouldCallRequestPermission = true |
Collaborator
There was a problem hiding this comment.
мне не очень нравится, что InAppActionResult универсальынй, а у него какое-то действие RequestPermission, которое не для всех инапов.
Я до добавил что нибудь универсальное, типо колбека onCompleted: () -> Unit и туда поместил mindboxView?.requestPermission()
Так будет универсальнее
Collaborator
Author
There was a problem hiding this comment.
мы хотим использовать колбэки не для асинхронного кода? помню у меня было замечания от тебя или Роберта по поводу использования колбэков для синхронного кода
А в целом мне так тоже больше нравится
enotniy
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/mindbox-cloud/issues-web-mobile/issues/3181