Skip to content

MBX-3355: set method call handler on init #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2024
Merged

MBX-3355: set method call handler on init #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 22 additions & 24 deletions mindbox_platform_interface/lib/src/types/mindbox_method_handler.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,11 @@ class MindboxMethodHandler {
'before initialization.');
}
await channel.invokeMethod('init', configuration.toMap());

if (!_methodHandlerSet) {
_setMethodCallHandler();
}

for (final callbackMethod in _pendingCallbackMethods) {
callbackMethod.callback(
await channel.invokeMethod(callbackMethod.methodName) ?? 'null');
Expand Down Expand Up @@ -144,19 +149,13 @@ class MindboxMethodHandler {
required PushClickHandler handler,
}) {
_pushClickHandler = handler;
if (!_methodHandlerSet) {
_setMethodCallHandler();
}
}

/// Method for handling In-app click.
void handleInAppClick({
required InAppClickHandler handler,
}) {
_inAppClickHandler = handler;
if (!_methodHandlerSet) {
_setMethodCallHandler();
}
registerInAppCallbacks(callbacks: [
CustomInAppCallback(
_inAppClickHandler ?? (id, redirectUrl, payload) => {},
Expand All @@ -170,9 +169,6 @@ class MindboxMethodHandler {
required InAppDismissedHandler handler,
}) {
_inAppDismissedHandler = handler;
if (!_methodHandlerSet) {
_setMethodCallHandler();
}
registerInAppCallbacks(callbacks: [
CustomInAppCallback(
_inAppClickHandler ?? (id, redirectUrl, payload) => {},
Expand Down Expand Up @@ -291,22 +287,24 @@ class MindboxMethodHandler {

void _setMethodCallHandler() {
channel.setMethodCallHandler((call) {
if (call.method == 'pushClicked') {
if (call.arguments is List) {
_pushClickHandler?.call(call.arguments[0], call.arguments[1]);
switch (call.method) {
case 'pushClicked':
if (call.arguments is List) {
_pushClickHandler?.call(call.arguments[0], call.arguments[1]);
}
break;
case 'onInAppClick':
if (call.arguments is List) {
Copy link
Collaborator

@enotniy enotniy May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

можно сюда логов добавить? А то кажется, где то здесь проблема с кликами в inapp и пайлоад

Copy link
Collaborator Author

@sergeysozinov sergeysozinov May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не получится сюда добавить. Возможно, стоит завести задачку, чтобы мы могли на стороне Flutter прокидывать логи в натив

Copy link
Collaborator

@enotniy enotniy May 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Возможно, к тому же надо туда же прокидывать информацию о том, что это Flutter, чтобы в user-agent вставлять

Copy link
Collaborator Author

@sergeysozinov sergeysozinov May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Закину на доску техдолга тогда

_inAppClickHandler?.call(
call.arguments[0], call.arguments[1], call.arguments[2]);
}
break;
case 'onInAppDismissed':
if (call.arguments is String) {
_inAppDismissedHandler?.call(call.arguments);
}
break;
}
}
if (call.method == 'onInAppClick') {
if (call.arguments is List) {
_inAppClickHandler?.call(
call.arguments[0], call.arguments[1], call.arguments[2]);
}
}
if (call.method == 'onInAppDismissed') {
if (call.arguments is String) {
_inAppDismissedHandler?.call(call.arguments);
}
}
return Future.value(true);
});
_methodHandlerSet = true;
Expand Down