WMSDK-533: Add stopwatch use #600
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds stopwatch functionality to measure and log the SDK initialization time. The changes integrate a stopwatch utility from MindboxCommon to track how long the Mindbox SDK takes to initialize.
- Adds stopwatch timing around SDK initialization in CoreController
- Updates project configuration to use local MindboxCommon dependency instead of remote
- Updates CI workflows to build the local MindboxCommon dependency
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Mindbox/CoreController/CoreController.swift | Adds stopwatch start/stop calls around initialization with logging |
| Mindbox.xcodeproj/project.pbxproj | Updates package dependency from remote to local MindboxCommon reference |
| .github/workflows/publish-reusable.yml | Adds Java setup and local kmp-common-sdk build steps |
| .github/workflows/linter_and_unit_tests.yml | Adds Java setup and local kmp-common-sdk build steps |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| func initialization(configuration: MBConfiguration) { | ||
|
|
||
| controllerQueue.async { | ||
| MindboxUtils.Stopwatch.shared.start(tag: MindboxUtils.Stopwatch.shared.INIT_SDK) |
There was a problem hiding this comment.
Consider extracting the stopwatch tag into a constant to avoid repeating MindboxUtils.Stopwatch.shared.INIT_SDK multiple times and improve maintainability.
| files = ( | ||
| A170EDDC29B0883800CE547F /* MindboxLogger.framework in Frameworks */, | ||
| B4AD28942E66EC5D008AEFCD /* MindboxCommon in Frameworks */, | ||
| B4F2BA192E8BE7E100A89C73 /* MindboxCommon in Frameworks */, |
There was a problem hiding this comment.
There appears to be a duplicate MindboxCommon framework reference in the Frameworks section (lines 1234 and 1235). This could cause build issues or confusion.
| B4F2BA192E8BE7E100A89C73 /* MindboxCommon in Frameworks */, |
https://tracker.yandex.ru/WMSDK-533