WMSDK-543: Migrate metadata from MBDatabase to PersistenceStorage (UserDefaults)
#603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…torage - Move metadata handling out of `DatabaseRepositoryProtocol` and into a dedicated `DatabaseMetadataMigration`. - Read/write metadata directly via `store.metadata` (through `MBDatabaseRepository persistentContainer`) inside the migration—no public getters/setters on the protocol. - Make the migration idempotent: - isNeeded checks that target PersistenceStorage fields are empty and source metadata keys exist. - Safely clears keys via metadata update (no-op if store is unavailable). - Document the repair & preservation flow with SwiftDoc: - `salvageMetadataFromOnDiskStore()`, `applyMetadata(_:to:)`. `loadPersistentContainer()`. `destroy()`. and `makeInMemoryContainer()`. - Naming: prefer suffix style for migrations; e.g. ShownInAppIDsMigration.
Contributor
Author
|
По тестам может что-то ещё нужно где-то дописать.. Я не нашел. Может ты что-то увидишь. |
justSmK
commented
Oct 1, 2025
Mindbox/Utilities/Migrations/ImplementationOfMigrations/DatabaseMetadataMigration.swift
Outdated
Show resolved
Hide resolved
…eded` for CoreData → UserDefaults metadata
- Add “cleanup-only” path to DatabaseMetadataMigration:
- If destination (PersistenceStorage) already has values but Core Data metadata
still contains keys, migration runs only to clear metadata on the store.
- Refine `isNeeded`:
- true if copy is needed (destination is nil and metadata exists), OR
- true if cleanup is needed (destination is set and metadata still exists).
- Make `run()` idempotent and safe:
- Write to PersistenceStorage only when destination fields are nil.
- Always clear both metadata keys to avoid future re-triggers.
- Keep version = 3 (no change in migration ordering).
- Tests:
- Added coverage for cleanup-only, copy-only, partial-copy, idempotence,
and no-op when nothing to migrate.
- Minor: avoid accidentally storing Optional<T> into metadata dictionary.
Why:
- On first launch the app may fall back to InMemory and migrate there; a later
on-disk launch could still carry stale metadata. Cleanup-only ensures the store
is sanitized without overwriting destination values.
Vailence
approved these changes
Oct 3, 2025
| } | ||
|
|
||
| private func install(deviceUUID: String, configuration: MBConfiguration) { | ||
| persistenceStorage.eraseApplicationInfoUpdateVersionAndInstanceId() |
Collaborator
There was a problem hiding this comment.
Мб тут не будем усложнять, и оставим eraseMetadata?
Contributor
Author
There was a problem hiding this comment.
Думал об этом. А мы точно вспомним что там за метадата удаляется? Или по реализации метода поймем? Поэтому конкретики добавил в названии метода.
Collaborator
There was a problem hiding this comment.
имхо, почитаем и поймем
плюс тесты есть на это
Change `eraseApplicationInfoUpdateVersionAndInstanceId` to `eraseMetadata`, fix comments and add docs
Contributor
Author
|
|
Vailence
approved these changes
Oct 7, 2025
justSmK
deleted the
feature/WMSDK-543-migrate-metadata-from-mbdatabase-to-userdefaults
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue