Skip to content

Conversation

@fg-mindee
Copy link
Contributor

@fg-mindee fg-mindee commented Feb 19, 2021

This PR introduces the following changes:

  • fixed the duplication of activation in conv_sequece in a specific case
  • added unittest to check the fix

This is a breaking change as previous checkpoints won't be working anymore.

Any feedback is welcome!

@fg-mindee fg-mindee added type: bug Something isn't working module: models Related to doctr.models ext: tests Related to tests folder labels Feb 19, 2021
@fg-mindee fg-mindee added this to the 0.1.0 milestone Feb 19, 2021
@fg-mindee fg-mindee self-assigned this Feb 19, 2021
@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #101 (f78563c) into main (d13b8ce) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   97.82%   97.94%   +0.12%     
==========================================
  Files          26       26              
  Lines         826      826              
==========================================
+ Hits          808      809       +1     
+ Misses         18       17       -1     
Flag Coverage Δ
unittests 97.94% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/utils.py 100.00% <100.00%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d13b8ce...57451b6. Read the comment docs.

@fg-mindee fg-mindee merged commit 79b80d3 into main Feb 19, 2021
@fg-mindee fg-mindee deleted the conv-seq-fix branch February 19, 2021 13:40
@fg-mindee fg-mindee added the type: breaking change Introducing a breaking change label Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ext: tests Related to tests folder module: models Related to doctr.models type: breaking change Introducing a breaking change type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants