Skip to content

Conversation

@charlesmindee
Copy link
Collaborator

Successfully merging this PR closes #71 , any feedback is welcome!

@charlesmindee charlesmindee added type: enhancement Improvement module: models Related to doctr.models labels Mar 2, 2021
@charlesmindee charlesmindee added this to the 0.2.0 milestone Mar 2, 2021
@charlesmindee charlesmindee requested a review from fg-mindee March 2, 2021 10:41
@charlesmindee charlesmindee self-assigned this Mar 2, 2021
@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #107 (938e5b1) into main (2c1d747) will decrease coverage by 0.09%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
- Coverage   97.88%   97.78%   -0.10%     
==========================================
  Files          28       28              
  Lines         897      904       +7     
==========================================
+ Hits          878      884       +6     
- Misses         19       20       +1     
Flag Coverage Δ
unittests 97.78% <90.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/recognition/sar.py 97.24% <90.00%> (-0.80%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c1d747...2400b0c. Read the comment docs.

Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR! I added a few comments

@charlesmindee charlesmindee requested a review from fg-mindee March 2, 2021 12:30
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the edits!

@charlesmindee charlesmindee merged commit 7996b4a into main Mar 2, 2021
@charlesmindee charlesmindee deleted the sar_teacher_forcing branch March 2, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: models Related to doctr.models type: enhancement Improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Models] Add SAR teacher forçing during training (decoder)

3 participants