refactor: PDF doc reader without bytestrings #18
Conversation
Codecov Report
@@ Coverage Diff @@
## main #18 +/- ##
==========================================
- Coverage 94.85% 91.11% -3.75%
==========================================
Files 8 4 -4
Lines 175 90 -85
==========================================
- Hits 166 82 -84
+ Misses 9 8 -1
Continue to review full report at Codecov.
|
|
I think you need to merge main before we move on to review! Also, if you could add a PR description, that would be great 🙏 |
|
Could you add a PR description as well please? 🙏 |
fg-mindee
left a comment
fg-mindee
left a comment
There was a problem hiding this comment.
Thanks for the PR! Apart from a little improvement in the tests, this looks good to me!
test/test_documents.py
Outdated
| DEFAULT_RES_MIN = int(0.8e6) | ||
| DEFAULT_RES_MAX = int(3e6) | ||
|
|
There was a problem hiding this comment.
you can remove this if we hardcode the expected values, which is preferrable
test/test_documents.py
Outdated
| assert shape[0] * shape[1] <= DEFAULT_RES_MAX | ||
| assert shape[0] * shape[1] >= DEFAULT_RES_MIN |
There was a problem hiding this comment.
Better to roll back to hardcoded int values 👌
test/test_documents.py
Outdated
| assert shape[0] * shape[1] <= int(3e6) | ||
| assert shape[0] * shape[1] >= int(0.8e6) |
There was a problem hiding this comment.
avoid unnecessary casting, let's write 3000000 and 800000
fg-mindee
changed the title
Module to load pdf as documents