chore: Fixed docker deps for cv2 #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #19 +/- ##
=======================================
Coverage 91.48% 91.48%
=======================================
Files 4 4
Lines 94 94
=======================================
Hits 86 86
Misses 8 8 Continue to review full report at Codecov.
|
charlesmindee
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cv2 dependency of the docker is not correctly set up by pip and some OS-level deps are needed. This PR adds required dependencies for opencv.
Surprisingly, pip was not doing a good job at it: by adding the OS-level deps, the image size drops significantly from 1.2Gb+ to less than 700Mb.
Expected docker image size is 673Mb, the build is a bit longer than before with the OS deps installation.
Any feedback is welcome!