Skip to content

Conversation

@charlesmindee
Copy link
Collaborator

This PR fixes 2 bugs spotted on the demo:

  • multi-pages pdf were crashing the app
  • pdf reader as images was outputing BGR instead of RGB

Any feedback is welcome!

@charlesmindee charlesmindee added type: bug Something isn't working module: io Related to doctr.io demo labels May 21, 2021
@charlesmindee charlesmindee added this to the 0.2.1 milestone May 21, 2021
@charlesmindee charlesmindee requested a review from fg-mindee May 21, 2021 08:15
@charlesmindee charlesmindee self-assigned this May 21, 2021
@codecov
Copy link

codecov bot commented May 21, 2021

Codecov Report

Merging #276 (3072b91) into main (f959be6) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #276   +/-   ##
=======================================
  Coverage   96.94%   96.94%           
=======================================
  Files          48       48           
  Lines        1966     1966           
=======================================
  Hits         1906     1906           
  Misses         60       60           
Flag Coverage Δ
unittests 96.94% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/documents/reader.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f959be6...3072b91. Read the comment docs.

Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@charlesmindee charlesmindee merged commit e811f6b into main May 21, 2021
@charlesmindee charlesmindee deleted the demo branch May 21, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: io Related to doctr.io type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants