feat: Added SAR with VGG16 backbone to recognition models #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #38 +/- ##
==========================================
+ Coverage 97.54% 97.86% +0.31%
==========================================
Files 18 19 +1
Lines 408 469 +61
==========================================
+ Hits 398 459 +61
Misses 10 10
Continue to review full report at Codecov.
|
fg-mindee
suggested changes
Jan 26, 2021
Contributor
fg-mindee
left a comment
fg-mindee
left a comment
There was a problem hiding this comment.
Very clean PR! Just a few comments to take care of. Also, could you add it to https://github.com/teamMindee/doctr/blob/main/docs/source/models.rst for the documentation to stay updated please?
fg-mindee
suggested changes
Jan 26, 2021
Contributor
fg-mindee
left a comment
fg-mindee
left a comment
There was a problem hiding this comment.
You need to update the name in the unittest and we're good to go!
fg-mindee
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements SAR model (show, attend and read) as described in paper, with VGG16 feature extractor and keras backend.