Skip to content

Conversation

@charlesmindee
Copy link
Collaborator

Corrected:

  • super().__init__() in sar submodules
  • __call__ to call in all models subclassed from keras

@charlesmindee charlesmindee added the module: models Related to doctr.models label Jan 28, 2021
@charlesmindee charlesmindee self-assigned this Jan 28, 2021
@fg-mindee fg-mindee changed the title __call__ to call and super() refacto fix: Switched __call__ to call and added required super() Jan 28, 2021
@fg-mindee fg-mindee added this to the 0.1.0 milestone Jan 28, 2021
@fg-mindee fg-mindee added the critical High priority label Jan 28, 2021
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test failures seem unrelated to the PR, looks good to me!

@fg-mindee fg-mindee merged commit 5e467b7 into main Jan 28, 2021
@fg-mindee fg-mindee deleted the sarsuper branch January 28, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

critical High priority module: models Related to doctr.models

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants