Skip to content

Conversation

@fg-mindee
Copy link
Contributor

@fg-mindee fg-mindee commented Feb 3, 2021

This PR introduces the following modifications:

  • moved task-specific (but not architecture-specific) preprocessors to their respective core.py
  • improved documentation a bit

Here is how the landing page of the doc renders:
image

Any feedback is welcome!

@fg-mindee fg-mindee added topic: documentation Improvements or additions to documentation type: enhancement Improvement module: models Related to doctr.models labels Feb 3, 2021
@fg-mindee fg-mindee added this to the 0.1.0 milestone Feb 3, 2021
@fg-mindee fg-mindee self-assigned this Feb 3, 2021
@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #55 (a9b141f) into main (5afb0d7) will decrease coverage by 0.72%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
- Coverage   94.73%   94.01%   -0.73%     
==========================================
  Files          23       21       -2     
  Lines         703      685      -18     
==========================================
- Hits          666      644      -22     
- Misses         37       41       +4     
Impacted Files Coverage Δ
doctr/models/detection/__init__.py 100.00% <ø> (ø)
doctr/models/preprocessor.py 96.66% <ø> (ø)
doctr/models/recognition/__init__.py 100.00% <ø> (ø)
doctr/models/detection/core.py 93.93% <100.00%> (+1.08%) ⬆️
doctr/models/recognition/core.py 94.73% <100.00%> (+2.73%) ⬆️
doctr/models/core.py 78.84% <0.00%> (-7.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5afb0d7...a9b141f. Read the comment docs.

@fg-mindee fg-mindee merged commit e3886ac into main Feb 4, 2021
@fg-mindee fg-mindee deleted the model-refactor branch February 4, 2021 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: models Related to doctr.models topic: documentation Improvements or additions to documentation type: enhancement Improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants