fix: <eos> symbol removed from vocab str #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesmindee
added
type: bug
fg-mindee
changed the title
Codecov Report
@@ Coverage Diff @@
## main #74 +/- ##
==========================================
- Coverage 94.09% 93.54% -0.55%
==========================================
Files 23 23
Lines 745 744 -1
==========================================
- Hits 701 696 -5
- Misses 44 48 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
fg-mindee
suggested changes
Feb 9, 2021
Contributor
fg-mindee
left a comment
fg-mindee
left a comment
There was a problem hiding this comment.
I'm still confused about why we don't have to change the unittest 🤷♂️ I added extra suggestions to improve the PR
fg-mindee
reviewed
Feb 9, 2021
Contributor
fg-mindee
left a comment
fg-mindee
left a comment
There was a problem hiding this comment.
Only a comment suggestion but the rest looks fine to me!
fg-mindee
previously approved these changes
Feb 9, 2021
Contributor
fg-mindee
left a comment
fg-mindee
left a comment
There was a problem hiding this comment.
Thanks for this critical fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
symbol has been removed from vocab (but kept in _embedded), len(vocab) = size of the alphabet