Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions src/Mindee/Parsing/Passport/PassportV1Prediction.cs
Original file line number Diff line number Diff line change
Expand Up @@ -72,19 +72,30 @@ public sealed class PassportV1Prediction : PredictionBase
[JsonPropertyName("mrz2")]
public StringField Mrz2 { get; set; }

/// <summary>
/// Combine the MRZ lines.
/// </summary>
public string Mrz => $"{Mrz1.Value}{Mrz2.Value}";

/// <summary>
/// The surname of the person.
/// </summary>
[JsonPropertyName("surname")]
public StringField Surname { get; set; }

/// <summary>
///
/// The full name.
/// </summary>
public string FullName => $"{string.Join(" ", GivenNames.Select(gn => gn.Value))} {Surname.Value}";

/// <summary>
///
/// </summary>
/// <returns></returns>
public override string ToString()
{
StringBuilder result = new StringBuilder("-----Passport data-----\n");
StringBuilder result = new StringBuilder("----- Passport V1 -----\n");
result.Append($"Full name: {FullName}\n");
result.Append($"Given names: {string.Join(" ", GivenNames.Select(gn => gn.Value))}\n");
result.Append($"Surname: {Surname.Value}\n");
result.Append($"Country: {Country.Value}\n");
Expand All @@ -94,10 +105,11 @@ public override string ToString()
result.Append($"Expiry date: {ExpiryDate.Value}\n");
result.Append($"MRZ 1: {Mrz1.Value}\n");
result.Append($"MRZ 2: {Mrz2.Value}\n");
result.Append($"MRZ: {Mrz}\n");

result.Append("----------------------");
result.Append("----------------------\n");

return result.ToString();
return SummaryHelper.Clean(result.ToString());
}
}
}
31 changes: 26 additions & 5 deletions tests/Mindee.UnitTests/Parsing/Passport/PassportV1Test.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,36 @@ namespace Mindee.UnitTests.Parsing.Passport
[Trait("Category", "Passport V1")]
public class PassportV1Test
{
[Fact(Skip = "Waiting for the summary format update.")]
public async Task Execute_WithPassportData_MustSuccess()
[Fact]
public async Task Predict_CheckSummary()
{
var mindeeApi = GetMindeeApiForPassport();
var prediction = await mindeeApi.PredictAsync<PassportV1Prediction>(ParsingTestBase.GetFakePredictParameter());
var mindeeAPi = GetMindeeApiForPassport();
var prediction = await mindeeAPi.PredictAsync<PassportV1Prediction>(ParsingTestBase.GetFakePredictParameter());

var expected = File.ReadAllText("Resources/passport/response_v1/doc_to_string.txt");

Assert.Equal(expected, prediction.ToString());
var indexFilename = expected.IndexOf("Filename");
var indexEOL = expected.IndexOf("\n", indexFilename);

Assert.Equal(
expected.Remove(indexFilename, indexEOL - indexFilename + 1),
prediction.Inference.Prediction.ToString());
}

[Fact]
public async Task Predict_CheckSummary_WithMultiplePages()
{
var mindeeAPi = GetMindeeApiForPassport();
var prediction = await mindeeAPi.PredictAsync<PassportV1Prediction>(ParsingTestBase.GetFakePredictParameter());

var expected = File.ReadAllText("Resources/passport/response_v1/page0_to_string.txt");

var indexFilename = expected.IndexOf("Filename");
var indexEOL = expected.IndexOf("\n", indexFilename);

Assert.Equal(
expected.Remove(indexFilename, indexEOL - indexFilename + 1),
prediction.Inference.Pages.First().Prediction.ToString());
}

[Fact]
Expand Down