again with the PDF interfaces#319
Merged
ianardee merged 4 commits intorelease/5.0.0-alpha1from Apr 29, 2026
Merged
Conversation
ianardee
force-pushed
the
pdf-again
branch
2 times, most recently
from
44f1249 to
1500d02
Compare
sebastianMindee
requested changes
Apr 29, 2026
Collaborator
sebastianMindee
left a comment
sebastianMindee
left a comment
There was a problem hiding this comment.
fix PDF naming in methods
Comment on lines
+86
to
+89
| if (!this.isPDF()) { | ||
| return 1; | ||
| } | ||
| return getPdfOperation().getNumberOfPages(this.file); | ||
| return getPdfInputOperator().getPageCount(this.file); |
Collaborator
There was a problem hiding this comment.
why change the case in isPDF but not other Pdf names such as getPdfInputOperator?
Collaborator
Author
There was a problem hiding this comment.
oversight, thanks
Comment on lines
+114
to
+130
| public void compress( | ||
| public LocalInputSource compress( |
Collaborator
There was a problem hiding this comment.
Not necessarily objecting, but compress (or compress! in ruby) is an in-place operation everywhere else. The reasoning was that if the user wants to reduce the size of his files, it stands to reason to me that he wants to discard the larger input source in the process.
Collaborator
Author
There was a problem hiding this comment.
It is in place, in-memory. Only returning the object to allow chaining, but this is probably not a great idea, reverting.
ianardee
force-pushed
the
pdf-again
branch
2 times, most recently
from
808d07e to
fff0fb7
Compare
sebastianMindee
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Types of changes