Skip to content

Conversation

@ianardee
Copy link
Contributor

@ianardee ianardee commented May 23, 2023

Description

Classification field values are never None, make a simple class to represent those.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires a change to the official Guide documentation.

@ianardee ianardee requested a review from sebastianMindee May 23, 2023 09:04
@ianardee ianardee changed the title ✨ add a specific class for classifications, which are never … ✨ add a specific class for classifications, which are never None May 23, 2023
@ianardee ianardee force-pushed the add-classification-field branch from 1cbb44e to 6d672ef Compare May 23, 2023 10:02
@ianardee ianardee merged commit 0ecd9f5 into main May 23, 2023
@ianardee ianardee deleted the add-classification-field branch May 23, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants