Skip to content

Conversation

@ianardee
Copy link
Contributor

Fix probabilities not loaded from API

Description

API response was changed, probability is now confidence, we need to update the SDK.

We are not changing the Field.probability in the SDK for backwards compatibility.

This will be changed in the upcoming v2.

How Has This Been Tested

New unit tests added, all tests updated.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Contributor

@fharper fharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I wasn't able to test it (pikepdf building issue on my machine, need to look at that)

Copy link
Contributor

@jonathanMindee jonathanMindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

The naming "probability" in the FIeld attribute should be avoid in the future. I propose we put this in the backlog and change the probabiillty name for the V2 or the next release to "confidence.

@ianardee ianardee merged commit c756f86 into main Jan 27, 2022
@ianardee ianardee deleted the fix-probabilities branch January 27, 2022 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants