Skip to content

🐛 fix for locale constructor #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2022
Merged

🐛 fix for locale constructor #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bac9c6a
:bug: fix for locale constructor
ianardee Mar 10, 2022
1f9824b
make more pythonic
ianardee Mar 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions mindee/fields/locale.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,7 @@ def __init__(

@staticmethod
def _get_value(locale_prediction, key: str):
if (
key not in locale_prediction.keys()
or locale_prediction["language"] == "N/A"
):
if key not in locale_prediction or locale_prediction[key] == "N/A":
return None
return locale_prediction[key]

Expand Down
15 changes: 15 additions & 0 deletions tests/fields/test_locale.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,18 @@ def test_constructor_almost_empty_field():
assert locale.language is None
assert locale.country is None
assert locale.currency is None


def test_constructor_empty_language():
field_dict = {
"value": "en-EN",
"country": "uk",
"currency": "GBP",
"language": "N/A",
"confidence": 0.1,
}
locale = Locale(field_dict)
assert locale.language is None
assert locale.country == "uk"
assert locale.currency == "GBP"
assert str(locale) == "en-EN; uk; GBP;"