Skip to content

Conversation

@ianardee
Copy link
Contributor

@ianardee ianardee commented Jun 16, 2022

✨ add real bounding box

API's polygon property is now set to the new field property polygon.

Existing field property bbox is now an actual calculated bounding box.

For OTS products this will have no effect, since currently polygons are always rectangular bounding boxes.

Will be useful when we transition custom docs to object fields.

Motivation and Context

Required work for Cropper feature and having classes in the custom document response.

How Has This Been Tested

New unit tests.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@ianardee ianardee requested review from YanisMindee and fharper June 16, 2022 12:47
Copy link
Contributor

@fharper fharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ianardee ianardee merged commit 59cbecf into main Jun 16, 2022
@ianardee ianardee deleted the add-geometry branch June 16, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants