Switch linter to only pick up _new_ issues#6440
Merged
JAORMX merged 1 commit intomindersec:mainfrom May 5, 2026
Merged
Conversation
|
coverage: 60.445% (+0.003%) from 60.442% — evankanderson:fix-lints into mindersec:main |
JAORMX
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It turns out that golangci-lint enabled
goconstanalysis, which flags > 100 strings as "repeated enough times to use a const", breaking lint for all PRs. Switch the check to only apply to new code. I'm also considering pinning the golangci-lint version (as the last two upgrades have done this sort of breakage), but I'm not sure that this wouldn't cause us to simply fall behind and never update.Testing
We'll see on this PR, which shouldn't flag any issues.