Skip to content

Change request_cls to prevent unintended bytes -> str conversion #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2022
Merged

Change request_cls to prevent unintended bytes -> str conversion #176

merged 1 commit into from
Apr 25, 2022

Conversation

@michael-lazar
Copy link
Contributor

@michael-lazar michael-lazar commented Apr 25, 2022

Fixes #175

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mindflayer mindflayer changed the base branch from master to fix/request_cls April 25, 2022 06:35
@mindflayer mindflayer merged commit 9de4e5f into mindflayer:fix/request_cls Apr 25, 2022
mindflayer added a commit that referenced this pull request Apr 25, 2022
@mindflayer @michael-lazar
MocketEntry.request_class str vs bytes (#177)
f03ca83 
* Change request_cls to prevent unintended bytes -> str conversion (#176)
* Use type from `.compat`.

Co-authored-by: Michael Lazar <lazar.michael22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MocketEntry.request_class str vs bytes

2 participants

@michael-lazar @mindflayer